[U-Boot] [PATCH] Add NanoBone board support

Mark Jackson mpfj-list at mimc.co.uk
Tue Apr 16 21:31:19 CEST 2013


On 16/04/13 20:27, Tom Rini wrote:
> On Tue, Apr 16, 2013 at 08:25:17PM +0100, Mark Jackson wrote:
>> On 16/04/13 20:14, Mark Jackson wrote:
>>> On 16/04/13 16:48, Tom Rini wrote:
>>>> On Tue, Apr 16, 2013 at 04:02:34PM +0100, Mark Jackson wrote:
>>
>> <snip>
>>
>>>>> +#define    CONFIG_SYS_NAND_ECCTOTAL    (CONFIG_SYS_NAND_ECCBYTES * \
>>>>> +                        CONFIG_SYS_NAND_ECCSTEPS)
>>>>> +
>>>>> +#define    CONFIG_SYS_NAND_U_BOOT_START    CONFIG_SYS_TEXT_BASE
>>>>
>>>> Another problem duplicated from am335x_evm.h :(
>>>
>>> I'll add it to the "remove duplicates" patch.
>>
>> Replied a bit too soon on this one ... I thought they were
>> duplicated, but they're not.
>>
>> what's the problem with these lines ?
>
> '#define<tab>' not '#define<space>'.  A general fixup patch is fine.

Actually, neither CONFIG_SYS_NAND_ECCTOTAL nor CONFIG_SYS_NAND_ECCSTEPS 
are used anywhere in the code !!

I'll just remove them.


More information about the U-Boot mailing list