[U-Boot] [PATCH 6/6] arm: mx5: Add support for DENX M53EVK

[Fabio Estevam]

On Fri, Apr 19, 2013 at 1:10 AM, Marek Vasut <marex at denx.de> wrote:
> Add basic support for the DENX M53EVK board. Currently supported is
> the MMC, Ethernet, I2C.

What about NAND, SATA and USB ?

> --- /dev/null
> +++ b/board/denx/m53evk/Makefile
> @@ -0,0 +1,40 @@
> +#
> +# DENX M53EVK
> +# Copyright (C) 2012-2013 Marek Vasut <marex at denx.de>
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> +# MA 02111-1307 USA

You could just remove the adress paragraph. Same for other places in this patch.

> +u32 get_board_rev(void)
> +{
> +       struct iim_regs *iim = (struct iim_regs *)IMX_IIM_BASE;
> +       struct fuse_bank *bank = &iim->bank[0];
> +       struct fuse_bank0_regs *fuse =
> +               (struct fuse_bank0_regs *)bank->fuse_regs;
> +       int rev = readl(&fuse->gp[6]);
> +
> +       return (get_cpu_rev() & ~(0xF << 8)) | (rev & 0xF) << 8;
> +}

Can't you just remove this get_board_rev() from the board file and use
the generic one instead?

> +/*
> + * Do not overwrite the console
> + * Use always serial for U-Boot console
> + */
> +int overwrite_console(void)
> +{
> +       return 1;
> +}
> +

Is this really needed? It doesn't seem so, as you do not use splash screen.

> +int board_init(void)
> +{
> +       gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
> +
> +       mxc_set_sata_internal_clock();
> +
> +       mxc_set_clock(0, 33, MXC_NFC_CLK);

Can you put a comment explaining which frequency you are setting
MXC_NFC_CLK to ?

> +/*
> + * U-Boot Commands
> + */

In this file you use multi-line style for single line comments.

You could simply do:

/*   U-Boot Commands */

> +#define CONFIG_SYS_MALLOC_LEN          (10 * 1024 * 1024)

Why do you need such large size?

> +#define CONFIG_SYS_MEMTEST_START       0x70010000
> +#define CONFIG_SYS_MEMTEST_END         0x70020000

Are these values correct? You are only testing 64kB of the RAM.