[U-Boot] [PATCH 4/4] watchdog: Add support for Xilinx Microblaze watchdog

Tom Rini trini at ti.com
Mon Apr 22 17:53:15 CEST 2013


On Mon, Apr 22, 2013 at 04:41:03PM +0200, Michal Simek wrote:

> Watchdog can be used on Microblaze, PPC and Zynq hw designs.
[snip]
> +++ b/drivers/watchdog/xilinx_tb_wdt.c
[snip]
> +#define watchdog_base ((struct watchdog_regs *)CONFIG_WATCHDOG_BASEADDR)

Just do:
static struct watchdog_regs *watchdog_base = CONFIG_WATCHDOG_BASEADDR;

[snip]
> +/* watchdog */
> +#if defined(XILINX_WATCHDOG_BASEADDR) && defined(XILINX_WATCHDOG_IRQ)
> +# define CONFIG_WATCHDOG_BASEADDR	XILINX_WATCHDOG_BASEADDR
> +# define CONFIG_WATCHDOG_IRQ		XILINX_WATCHDOG_IRQ
> +# define CONFIG_HW_WATCHDOG		1
> +# define CONFIG_XILINX_TB_WATCHDOG	1

Just '#define' and no 1 for options that we only need to set please,
thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130422/cbed4af2/attachment.pgp>


More information about the U-Boot mailing list