[U-Boot] [PATCH v4 01/10] imx: Homogenize and fix fuse register definitions

[Stefano Babic]

On 23/04/2013 22:17, Benoît Thébaudeau wrote:
> IIM:
>  - Homogenize prg_p naming (the reference manuals are not always self-consistent
>    for that).
>  - Add missing SCSx and bank registers.
>  - Fix the number of banks on i.MX53.
> 
> OCOTP:
>  - Rename iim to ocotp in order to avoid confusion.
>  - Rename fuse_data to read_fuse_data, and sticky to sw_sticky, according to the
>    reference manual.
>  - Merge the existing spinoff gp1 fuse definition on i.MX6.
>  - Fix the number of banks on i.MX6.
> 
> Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau at advansee.com>
> ---

Hi Benoît.

I would like to apply your patches and I see some warning from
clearpatch. Some of them are very annoying and I think to ignore them,
but before doing that I ask to ML about it. It seems to me that
checkpatch make stonger tests as in the past, and I do not know if all
of them are meaningful. Or better, I do not think they are.

Here the warnings:

CHECK: Alignment should match open parenthesis
#589: FILE: common/cmd_fuse.c:77:
+	if (argc < 2 || strtou32(argv[0], 0, &bank) ||
+			strtou32(argv[1], 0, &word))

CHECK: Alignment should match open parenthesis
#637: FILE: common/cmd_fuse.c:125:
+			printf("Programming bank %u word 0x%.8x to 0x%.8x...\n",
+					bank, word, val);


I would say that this enforcement is crap. The code in the patch is easy
to read. I want to ignore this warning.



WARNING: quoted string split across lines
#653: FILE: common/cmd_fuse.c:141:
+			printf("Overriding bank %u word 0x%.8x with "
+					"0x%.8x...\n", bank, word, val);


Again, this is the solution when a line is too long. checkpatch
complains if a line is too long, and in case of static string complains
that is splitted. This is too much, I would like to ignore also this one.


CHECK: Alignment should match open parenthesis
#1102: FILE: drivers/misc/fsl_iim.c:118:
+	if (bank >= ARRAY_SIZE((*regs)->bank) ||
+			word >= ARRAY_SIZE((*regs)->bank[0].word) ||

Ditto

WARNING: line over 80 characters
#1190: FILE: drivers/misc/fsl_iim.c:206:
+		puts("fsl_iim fuse_sense(): Explicit sense cycle did not complete\n");


Ok, this is the one that must be fixed, even if then we have the warning
with "quoted string"

WARNING: line over 80 characters
#2017: FILE: drivers/misc/mxc_ocotp.c:8:
+ *
http://git.freescale.com/git/cgit.cgi/imx/uboot-imx.git/tree/drivers/misc/imx_otp.c?h=imx_v2009.08_1.1.0&id=9aa74e6,

Ditto

CHECK: Alignment should match open parenthesis
#2088: FILE: drivers/misc/mxc_ocotp.c:79:
+	if (bank >= ARRAY_SIZE((*regs)->bank) ||
+			word >= ARRAY_SIZE((*regs)->bank[0].fuse_regs) >> 2 ||

I will not care about this.


Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================