[U-Boot] [PATCH 2/7] powerpc/boot: Change the macro of Boot from SRIO and PCIE master module

Andy Fleming afleming at gmail.com
Mon May 6 20:58:07 CEST 2013


York has submitted a bunch of patches. I marked yours as superseded to note
that I'll take his copy. There are others like that, but I'm holding off on
deciding which copy to take until I can review them.


On Sun, May 5, 2013 at 10:28 PM, Liu Gang <Gang.Liu at freescale.com> wrote:

> On Tue, 2013-04-30 at 17:28 -0500, Andy Fleming wrote:
>
>
> > On Fri, Mar 8, 2013 at 2:41 AM, Liu Gang <Gang.Liu at freescale.com>
> > wrote:
> >         Change the macro "CONFIG_SYS_FSL_SRIO_PCIE_BOOT_MASTER" to
> >         "CONFIG_SRIO_PCIE_BOOT_MASTER", remove them from
> >         arch/powerpc/include/asm/config_mpc85xx.h file, and add those
> >         macros
> >         in configuration header file of each board which can support
> >         the
> >         master module of Boot from SRIO and PCIE.
> >
> >         Signed-off-by: Liu Gang <Gang.Liu at freescale.com>
> >
> >
> >
> >
> > More important than explaining what the patch does is explaining
> > *why*. Why was this change necessary?
> >
> >
> > Make sure the "why" includes what makes this feature a board feature,
> > as opposed to an SoC feature?
> >
> >
> > Andy
> Thanks, I'll updated the commit message.
> And in addition, why the state of the below patch is superseded?
> http://patchwork.ozlabs.org/patch/226046/
>
>
>
>


More information about the U-Boot mailing list