[U-Boot] [PATCH 2/4] mpc8xx: Correct cast of im_cpm.cp_dparam

Wolfgang Denk wd at denx.de
Tue May 14 00:34:47 CEST 2013


Dear Tom Rini,

In message <1368477117-32669-2-git-send-email-trini at ti.com> you wrote:
> We must cast this to unsigned char not unsigned short to avoid warnings.

But this is wrong.  We're actually reading a 16 bit value here.

I think there was previous discussion, and Scott Wodd has a patch out
there, which just needed some minor fixing...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is impractical for  the  standard  to  attempt  to  constrain  the
behavior  of code that does not obey the constraints of the standard.
                                                          - Doug Gwyn


More information about the U-Boot mailing list