[U-Boot] [PATCH 2/4] mpc8xx: Correct cast of im_cpm.cp_dparam

Wolfgang Denk wd at denx.de
Tue May 14 12:26:19 CEST 2013


Dear Tom,

In message <20130513223447.5D86C3804AF at gemini.denx.de> I wrote:
> 
> In message <1368477117-32669-2-git-send-email-trini at ti.com> you wrote:
> > We must cast this to unsigned char not unsigned short to avoid warnings.
> 
> But this is wrong.  We're actually reading a 16 bit value here.
> 
> I think there was previous discussion, and Scott Wodd has a patch out
> there, which just needed some minor fixing...

Scott's patch is here:

http://patchwork.ozlabs.org/patch/210599/

Scott, do you have any plans to submit an updated version?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All men should freely use those seven words which have the  power  to
make any marriage run smoothly: You know dear, you may be right.


More information about the U-Boot mailing list