[U-Boot] ulpi patch in uboot

[Michael Trimarchi]

Hi Stefano

On 16/05/13 12:34, Stefano Babic wrote:
> On 16/05/2013 11:42, Michael Trimarchi wrote:
>> Hi a;;,
>>
> 
> Hi Michael,
> 
> (I posted also to u-boot ML to check if someone else had issues)
> 
>> I think that this patch could be wrong for omap4 and omap3. The opcode shift
>> shuld be 22 and not 21. And are you sure that are you using the bit 31
>> in the correct way?
>>
>> Stefano, are you sure about your testing?
> 
> Well, it happened more as one year ago, but I tested again this morning
> with the AM3517 I used for testing, using a version 2013.04-rc1
> 
> twister => usb start
> (Re)start USB...
> USB0:   USB EHCI 1.00
> scanning bus 0 for devices... 3 USB Device(s) found
>        scanning usb for storage devices... 1 Storage Device(s) found
> twister => fatls usb 0
>             .disk/
> 

Sorry this does not show nothing. The phy use reset value.
Read and write command are wrong, the shift is wrong and the timeout condition is wrong
look at documentation. If I use the documentation the ulpi always timeout. In order
to have a proof of concept you need to read and print vendor id and product id.

Michael



> So it seems working - I have not yet checked in manual, but if the shift
> is wrong, it seems it has no drawbacks on my board ;-(
> 
> Best regards,
> Stefano
> 
>>
>> Michael
>>
>> commit 928c4bdf9b069be218436d25b96721395c4d671f
>> Author: Govindraj.R <govindraj.raja at ti.com>
>> Date:   Mon Feb 6 03:55:32 2012 +0000
>>
>>     usb: ulpi: Add omap-ulpi-view port support
>>     
>>     Based on discussion from this thread [1].
>>     Adding omap-view port that helps us in using the generic ulpi
>>     framework for any ulpi phy ops using the INSNREG05_ULPI viewport
>>     reg available on omap platform.
>>     
>>     Currently ehci ports are available on omap3/4 platforms so enable the same
>>     for beagle and panda, patch is tested on the same boards.
>>     
>>     Thanks to Igor Grinberg <grinberg at compulab.co.il> for reviewing the
>>     omap-ehci patches and suggesting this approach.
>>     
>>     [1]: http://www.mail-archive.com/u-boot@lists.denx.de/msg76076.html
>>
>>
> 
>