[U-Boot] [PATCH] mtd: spi: winbond: add W25PXX support

[Kuo-Jung Su]

2013/5/23 Jagan Teki <jagannadh.teki at gmail.com>:
> On Thu, May 23, 2013 at 3:24 PM, Kuo-Jung Su <dantesu at gmail.com> wrote:
>> 2013/5/23 Jagan Teki <jagannadh.teki at gmail.com>:
>>> Hi,
>>>
>>> On Wed, May 22, 2013 at 6:31 AM, Kuo-Jung Su <dantesu at gmail.com> wrote:
>>>> 2013/5/22 Jagan Teki <jagannadh.teki at gmail.com>:
>>>>> Hi,
>>>>>
>>>>> I have a simple question like these parts are legacy flashes i guess.
>>>>> Could you please tell me on which boards these were used?
>>>>>
>>>>
>>>> It's used on Faraday A369 evaluation board.
>>>> However the u-boot source codes for A369 is still waiting for approval.
>>>> Here is the link to u-boot patchwork:
>>>
>>> Ok, Thanks for your information.
>>>
>>>>
>>>> http://patchwork.ozlabs.org/patch/242006/
>>>>
>>>>> Thanks,
>>>>> Jagan.
>>>>>
>>>>> On Fri, Apr 26, 2013 at 1:32 PM, Kuo-Jung Su <dantesu at gmail.com> wrote:
>>>>>> From: Kuo-Jung Su <dantesu at faraday-tech.com>
>>>>>>
>>>>>> Signed-off-by: Kuo-Jung Su <dantesu at faraday-tech.com>
>>>>>> ---
>>>>>>  drivers/mtd/spi/winbond.c |   17 ++++++++++++++++-
>>>>>>  1 file changed, 16 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
>>>>>> index 2716209..2a27837 100644
>>>>>> --- a/drivers/mtd/spi/winbond.c
>>>>>> +++ b/drivers/mtd/spi/winbond.c
>>>>>> @@ -18,6 +18,21 @@ struct winbond_spi_flash_params {
>>>>>>
>>>>>>  static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
>>>>>>         {
>>>>>> +               .id                     = 0x2014,
>>>>>> +               .nr_blocks              = 16,
>>>>>> +               .name                   = "W25P80",
>>>
>>> W25P80 is an 8Mbit flash right, is this name W25P80 or W25P08?
>>> ofcourse, I have seen the same on datasheet as well.
>>>
>>
>> It's W25P80.
>> They are formally NexFlash NX25P80, NX25P16 and NX25P32.
>>
>> I've google for the W25P08, it looks like that Windond did have
>> some legacy small SPI flash: W25P01, W25P02 .. W25P16.
>> I guess it's a different production line...
>>
>> BTW I don't have these chips and corresponding datasheet, too.
>
> Ok.
>
> Can you use the commit msg header as
> "sf: winbond: "
> Which is used for winbond mtd driver since from long, of-course not a
> big deal and
> also mentioned atleast single line message on body.
>

Sure, I'll re-format the patch and re-post again.

> Simple recommendation here:.
> "Add support for Winbond's W25PXX SPI flash.
> These devices is used on Faraday A369 evaluation board"
>

Thanks.
It's pretty helpful to me, because my English is really terrible. :)

> Thanks,
> Jagan.



--
Best wishes,
Kuo-Jung Su