[U-Boot] [RFC PATCH 4/7] Add Kconfig scripts and related material

Tom Rini trini at ti.com
Tue May 28 19:52:11 CEST 2013


On Tue, May 28, 2013 at 10:31:59AM +0900, Masahiro Yamada wrote:

[snip]
> So, my first request is that this commit should just import
> scripts as they are in Linux Kernel (plus renaming from
> Makefile to Makefile.kbuild)
> 
> All modification you make for U-Boot should be pushed into the
> next commit "Adjust Kconfig scripts for use by U-Boot".
> 
> I think this would be helpful for reviewers to track which lines
> are changed.
> 
> 
> The seconde request is subject of personal preference but I like
> the white spaces to be kept untouched when importing files
> from another project.
> 
> Although I was not sure they were corrected by you,
> I noticed some white space errors diffs when
> comparing your patches with Linux Kernel makefiles.
> The reason is, as you mentioned in commit log, to minimise conflicts
> with future Kbuild updates.

Agreed on both points.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130528/54f62e80/attachment.pgp>


More information about the U-Boot mailing list