[U-Boot] [RFC PATCH 4/7] Add Kconfig scripts and related material

Masahiro Yamada yamada.m at jp.panasonic.com
Tue May 28 03:31:59 CEST 2013


Hello, Simon.


> I can push my linux-next somewhere if that would help.

It is not necessary if you are going to pick up an official release.

I have two more requests when you post version 2.

You added Makefile.kbuild at commit
"Add Kconfig scripts and related material".
It seems to already include the modification for U-Boot.

So, my first request is that this commit should just import
scripts as they are in Linux Kernel (plus renaming from
Makefile to Makefile.kbuild)

All modification you make for U-Boot should be pushed into the
next commit "Adjust Kconfig scripts for use by U-Boot".

I think this would be helpful for reviewers to track which lines
are changed.


The seconde request is subject of personal preference but I like
the white spaces to be kept untouched when importing files
from another project.

Although I was not sure they were corrected by you,
I noticed some white space errors diffs when
comparing your patches with Linux Kernel makefiles.
The reason is, as you mentioned in commit log, to minimise conflicts
with future Kbuild updates.

Best regards,
Masahiro Yamada



More information about the U-Boot mailing list