[U-Boot] enabling ecc on P2041 and QoreIQ familly not valid for memory >= 4GB

York Sun yorksun at freescale.com
Wed Jul 23 00:53:33 CEST 2014


On 07/18/2014 06:11 AM, Benoit Sansoni wrote:
> Hi ,
> 
> I found out an issue when enabling ECC for P2041 platform with an amount
> of memory of 8GB.
> The routine "void dma_meminit(uint val, uint size)" is not adapted to
> manage memory size greater or equal to 4GB due to the 'uint' type.
> With this typing the dma_meminit sees 0 as size when memory is for
> example at 8GB. So the ECC part of the memory is not initialized and
> when going in memory the code crash.
> To correct it you need to use phys_size_t type instead of uint.
> It is the same thing for all routines that are called by "dma_meminit".
> I attached a patch that able to correct it easily.
> This patch should be integrated in the main branch I think so.
> 
> Regards,
> Benoit
> 

This is a valid concern. Some code started when we had far less memory. We need
to comb through the code to fix more of them.

York



More information about the U-Boot mailing list